-
-
Notifications
You must be signed in to change notification settings - Fork 631
[18.0][IMP] base_tier_validation: Adjustment to improve inheritance #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @LoisRForgeFlow, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CILC98
Thanks for contributing, could you change your commit message to English and follow the pattern "[TAG] module_name: short description"?
Thanks
ab65e92 to
de657e3
Compare
|
@LoisRForgeFlow Hi, I've changed the name as you suggested. Thanks |
5c27ccd to
3f184ed
Compare
|
@LoisRForgeFlow Hi and Happy new Year. Could you please review this pull request again? |
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Thanks for contributing /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1199-by-LoisRForgeFlow-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
1 similar comment
|
@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1199-by-LoisRForgeFlow-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@CILC98 Sorry, I aborted the merge, becuase the commit message was still not correct.
In this case it could be: "[IMP] base_tier_validation: Adjustment to improve inheritance" following what you already have. |
3f184ed to
1c31c92
Compare
|
@LoisRForgeFlow Thanks, I didn't realize I only did it locally. I just did it, please check it. |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b7b271b. Thanks a lot for contributing to OCA. ❤️ |

Improvement to make modifications to the exception search and the fields to enable during and after validation